Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x][Remote Store] Upload translog checkpoint as object metadata to trans… #13795

Merged

Conversation

skumawat2025
Copy link
Contributor

@skumawat2025 skumawat2025 commented May 23, 2024

Backport #13637 to 2.x

Conflicts files: CHANGELOG.md

  • Upload translog checkpoint as object metadata to translog
    Signed-off-by: Sandeep Kumawat [email protected]

Description

[Describe what this change achieves]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…log (opensearch-project#13637)

* Upload translog checkpoint as object metadata to translog
Signed-off-by: Sandeep Kumawat <[email protected]>
@skumawat2025 skumawat2025 force-pushed the backport-13637-to-2.x branch from ea4800c to de4e20c Compare May 23, 2024 08:31
@skumawat2025 skumawat2025 changed the title [Remote Store] Upload translog checkpoint as object metadata to trans… [Backport 2.x][Remote Store] Upload translog checkpoint as object metadata to trans… May 23, 2024
Copy link
Contributor

❌ Gradle check result for ea4800c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for de4e20c: SUCCESS

Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 75.88652% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 71.31%. Comparing base (0dd892c) to head (de4e20c).
Report is 269 commits behind head on 2.x.

Files Patch % Lines
...dex/translog/transfer/TranslogTransferManager.java 82.22% 5 Missing and 3 partials ⚠️
...g/transfer/TranslogCheckpointTransferSnapshot.java 0.00% 6 Missing ⚠️
...in/java/org/opensearch/index/shard/IndexShard.java 33.33% 4 Missing ⚠️
...ex/remote/RemoteMigrationIndexMetadataUpdater.java 62.50% 1 Missing and 2 partials ⚠️
.../org/opensearch/index/remote/RemoteStoreUtils.java 70.00% 0 Missing and 3 partials ⚠️
...ex/translog/transfer/BlobStoreTransferService.java 82.35% 2 Missing and 1 partial ⚠️
...ndex/remote/RemoteStoreCustomMetadataResolver.java 88.23% 2 Missing ⚠️
...va/org/opensearch/indices/RemoteStoreSettings.java 66.66% 2 Missing ⚠️
...rg/opensearch/repositories/s3/S3BlobContainer.java 0.00% 1 Missing ⚠️
...va/org/opensearch/repositories/s3/S3BlobStore.java 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #13795      +/-   ##
============================================
+ Coverage     71.28%   71.31%   +0.03%     
- Complexity    60145    61318    +1173     
============================================
  Files          4957     5037      +80     
  Lines        282799   288378    +5579     
  Branches      41409    42133     +724     
============================================
+ Hits         201591   205659    +4068     
- Misses        64189    65357    +1168     
- Partials      17019    17362     +343     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sachinpkale sachinpkale merged commit edcbdaf into opensearch-project:2.x May 23, 2024
54 checks passed
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…log (opensearch-project#13637) (opensearch-project#13795)

* Upload translog checkpoint as object metadata to translog
Signed-off-by: Sandeep Kumawat <[email protected]>
Signed-off-by: kkewwei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants